PR: Close terminal tab if process was closed #98
Conversation
| def test_close_terminal_manually(qtbot): | ||
| # Setup widget | ||
| terminal = setup_terminal(qtbot) | ||
| qtbot.wait(TERM_UP) |
There was a problem hiding this comment.
@andfoy is not there a signal that gets emitted when the terminal is ready?
There was a problem hiding this comment.
I thought that we had some mechanism in place to test when a terminal was up, and then emitted a signal when confirmed.
There was a problem hiding this comment.
@goanpeca I tried to put some kind of mechanism on place, however I didn't put it because sometimes it fails. Right now I have a way to know if the prompt is ready, I'll try to use it to emit a signal.
There was a problem hiding this comment.
@goanpeca If I use the ready signal, some tests start to fail randomly. I prefer to leave them as they are
There was a problem hiding this comment.
Ok, then, but in this case I think is better that the test has a timer that check every 1000 ms, and we define a maximum number of retries, to account for changes in CI times etc...
Fixes #96
Fixes #95