Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for nose #178

Closed
jitseniesen opened this issue Jun 27, 2022 · 3 comments · Fixed by #200
Closed

Remove support for nose #178

jitseniesen opened this issue Jun 27, 2022 · 3 comments · Fixed by #200
Assignees
Milestone

Comments

@jitseniesen
Copy link
Member

Nose has seen no updates since 2015, numpy switched away in 2018, I don't remember an explicit mention of nose in connection with this plugin in a long time, so I propose that we remove support for nose in v0.6 of this plugin.

@juliangilbey
Copy link

There is nose2 as a potential alternative: https://docs.nose2.io/en/latest/

Dmitry Shachnev (a Debian Python maintainer) has just proposed a mass-bug filing against packages still using nose: https://lists.debian.org/debian-python/2022/08/msg00065.html

So I'd be OK with seeing nose support removed from this plugin, though if nose2 is a reasonable substitute and it is relatively easy to switch the code from nose support to nose2 support, that might be preferable to a wholesale removal.

Best wishes, Julian

@jitseniesen
Copy link
Member Author

I saw that Dmitry went ahead and filed a bug against the Debian package. Since the nose dependency is optional (except for running the test suite), I guess you can just disable the tests that run nose in the Debian package if you want to get rid of the Build-Depends.

Regarding nose2, there has never been a demand for it and I don't use it myself so I am not super keen. However, it looks lie it may be really easy to change the code from nose to nose2. There are apparently thousands of repos on Github that use nose2 so it does see some use. I will try it and see how it goes. Thanks for the suggestion.

@jitseniesen jitseniesen self-assigned this Apr 6, 2023
@jitseniesen
Copy link
Member Author

It turns out it was quite easy to support nose2, so that is what I am going to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants