Skip to content

Commit

Permalink
Fix PyLS requirements and add Jedi 0.14.1 as a new dependency for now
Browse files Browse the repository at this point in the history
  • Loading branch information
ccordoba12 committed Oct 28, 2019
1 parent e94eb0e commit 299f9d2
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
3 changes: 2 additions & 1 deletion requirements/conda.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ atomicwrites
chardet >=2.0.0
cloudpickle
diff-match-patch
jedi =0.14.1

This comment has been minimized.

Copy link
@Jeroendevr

Jeroendevr Oct 29, 2019

jedi =0.14.1
Is this specific version needed '==' ? or better '>='. One '=' does not work on my machine.

This comment has been minimized.

Copy link
@ccordoba12

ccordoba12 Oct 29, 2019

Author Member

A single = is what works for conda.

This comment has been minimized.

Copy link
@Jeroendevr

Jeroendevr Oct 29, 2019

Thanks for replying, perhaps I am mixing two thing with each other. Because I was trying to run the development build using pip. After I did a pull SPYDER did not started. I saw that the requirements where changed so did a pip3 install -r /spyder/requirements/conda.txt which resulted in an error. Was this wrong and should I have done only a pip3 install -e .Then ?

This comment has been minimized.

Copy link
@ccordoba12

ccordoba12 Oct 29, 2019

Author Member

Because I was trying to run the development build using pip

I guessed that.

I saw that the requirements where changed so did a pip3 install -r /spyder/requirements/conda.txt

That's why this file is called conda.txt, i.e. because it only works with conda.

Was this wrong and should I have done only a pip3 install -e .

Yes, that's the right way to install our development version and all its dependencies. That's documented in our contributing guide:

https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md

This comment has been minimized.

Copy link
@Jeroendevr

Jeroendevr Oct 29, 2019

Ok thanks!

keyring
nbconvert
numpydoc
Expand All @@ -12,7 +13,7 @@ pygments >=2.0
pylint
pympler
pyqt <5.13
python-language-server >=0.29.2
python-language-server >=0.29.2,<0.30.0
pyxdg
pyzmq
qdarkstyle >=2.7
Expand Down
7 changes: 5 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -228,13 +228,16 @@ def run(self):
# pyqtwebengine module
'pyqtwebengine<5.13;python_version>="3"',
# Pyls with all its dependencies
'python-language-server[all]>=0.28.3,<0.29.0',
'python-language-server[all]>=0.29.2,<0.30.0',
# Required to get SSH connections to remote kernels
'pexpect',
'paramiko;platform_system=="Windows"',
# Required for accesing xdg spec on Linux
'pyxdg>=0.26;platform_system=="Linux"',
'pympler'
'pympler',
# Pseudo-dependency. To be removed when Jedi fixes completions
# for Numpy and Pandas
'jedi==0.14.1'
]

extras_require = {
Expand Down

0 comments on commit 299f9d2

Please sign in to comment.