Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError when hovering over value in dictionary editor #21191

Closed
jitseniesen opened this issue Jul 26, 2023 · 3 comments · Fixed by #21193
Closed

TypeError when hovering over value in dictionary editor #21191

jitseniesen opened this issue Jul 26, 2023 · 3 comments · Fixed by #21193

Comments

@jitseniesen
Copy link
Member

Description

What steps will reproduce the problem?

  1. Type dic = {'lst': [1,2,3]} in the console.
  2. Click on the value {'lst': [1,2,3]} of dic in the Variable Explorer to open the dictionary editor.
  3. Hover over the value [1, 2, 3] in the dictionary editor.

Traceback

Traceback (most recent call last):
  File "/apps/srv01/amt/jitse/misc/spyder/spyder/widgets/collectionseditor.py", line 410, in data
    return value['view']
TypeError: list indices must be integers or slices, not str

Versions

  • Spyder version: 6.0.0.dev0 a2e8f54 (conda)
  • Python version: 3.10.12 64-bit
  • Qt version: 5.15.6
  • PyQt5 version: 5.15.7
  • Operating System: Linux-3.10.0-1160.90.1.el7.x86_64-x86_64-with-glibc2.17

Dependencies

# Mandatory:
atomicwrites >=1.2.0                                                        :  1.4.1 (OK)
chardet >=2.0.0                                                             :  5.1.0 (OK)
cloudpickle >=0.5.0                                                         :  2.2.1 (OK)
cookiecutter >=1.6.0                                                        :  2.1.1 (OK)
diff_match_patch >=20181111                                                 :  20230430 (OK)
intervaltree >=3.0.2                                                        :  3.1.0 (OK)
IPython >=7.31.1,<9.0.0,!=8.8.0,!=8.9.0,!=8.10.0,!=8.11.0,!=8.12.0,!=8.12.1 :  8.14.0 (OK)
jedi >=0.17.2,<0.19.0                                                       :  0.18.2 (OK)
jellyfish >=0.7                                                             :  1.0.0 (OK)
jsonschema >=3.2.0                                                          :  4.17.3 (OK)
keyring >=17.0.0                                                            :  24.2.0 (OK)
nbconvert >=4.0                                                             :  7.6.0 (OK)
numpydoc >=0.6.0                                                            :  1.5.0 (OK)
parso >=0.7.0,<0.9.0                                                        :  0.8.3 (OK)
pexpect >=4.4.0                                                             :  4.8.0 (OK)
pickleshare >=0.4                                                           :  0.7.5 (OK)
psutil >=5.3                                                                :  5.9.5 (OK)
pygments >=2.0                                                              :  2.15.1 (OK)
pylint >=2.5.0,<3.0                                                         :  2.17.4 (OK)
pylint_venv >=3.0.2                                                         :  3.0.2 (OK)
pyls_spyder >=0.4.0                                                         :  0.4.0 (OK)
pylsp >=1.7.4,<1.8.0                                                        :  1.7.4 (OK)
pylsp_black >=1.2.0,<3.0.0                                                  :  1.3.0 (OK)
qdarkstyle >=3.0.2,<3.2.0                                                   :  3.1 (OK)
qstylizer >=0.2.2                                                           :  0.2.2 (OK)
qtawesome >=1.2.1                                                           :  1.2.3 (OK)
qtconsole >=5.4.2,<5.5.0                                                    :  5.5.0.dev0 (OK)
qtpy >=2.1.0                                                                :  2.3.1 (OK)
rtree >=0.9.7                                                               :  1.0.1 (OK)
setuptools >=49.6.0                                                         :  68.0.0 (OK)
sphinx >=0.6.6                                                              :  7.0.1 (OK)
spyder_kernels >=3.0.0b1,<3.0.0b2                                           :  3.0.0.dev0 (OK)
textdistance >=4.2.0                                                        :  4.5.0 (OK)
three_merge >=0.1.1                                                         :  0.1.1 (OK)
watchdog >=0.10.3                                                           :  3.0.0 (OK)
xdg >=0.26                                                                  :  0.28 (OK)
zmq >=22.1.0                                                                :  25.1.0 (OK)

# Optional:
cython >=0.21                                                               :  None (NOK)
matplotlib >=3.0.0                                                          :  3.7.2 (OK)
numpy >=1.7                                                                 :  1.25.0 (OK)
pandas >=1.1.1                                                              :  2.0.3 (OK)
scipy >=0.17.0                                                              :  None (NOK)
sympy >=0.7.3                                                               :  None (NOK)
@jitseniesen
Copy link
Member Author

The error is only in the master branch, not in the 5.x branch.

@jsbautista It looks like the line raising the TypeError was added in PR #20868, maybe you can have a look?

@ccordoba12
Copy link
Member

ccordoba12 commented Jul 26, 2023

Pinging @dalthviz about this one too. I think the problem is that the changes done in PR #20868 assume the only collections editor usage is the one in the Variable Explorer, where you can run value['view'] without issues.

The problem is other usages (like in @jitseniesen's example) are not working with remote data, so it's possible to do that in those cases.

@dalthviz
Copy link
Member

I will give this a check @ccordoba12 @jitseniesen 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants