Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Improve Variable Explorer UX #20868

Merged
merged 41 commits into from
Jul 14, 2023
Merged

PR: Improve Variable Explorer UX #20868

merged 41 commits into from
Jul 14, 2023

Conversation

jsbautista
Copy link
Contributor

@jsbautista jsbautista commented Apr 24, 2023 •
edited by dalthviz
Loading

Description of Changes

Fixes variable explorer UX issues

Depends on spyder-ide/spyder-kernels#460

Issue(s) Resolved

Fixes spyder-ide/ux-improvements#17

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
@jsbautista

@dalthviz dalthviz added this to the v6.0alpha2 milestone Apr 24, 2023
@jsbautista

This comment was marked as outdated.

Sign in to view
@jsbautista
Copy link
Contributor Author

Preview:
VariableExplorerPreview

@jsbautista jsbautista changed the title [WIP] PR: Variable explorer issues PR: Variable explorer issues May 25, 2023
dalthviz
dalthviz reviewed May 28, 2023
View reviewed changes
Copy link
Member

@dalthviz dalthviz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsbautista for the work here! Left an initial review with a comment regarding the changes related with spyder-kernels and a comment suggestion. Also, after a quick look to the tests, seems like the errors there are related with the changes here so a look to those is missing too.

If you have any question let me know!

external-deps/spyder-kernels/spyder_kernels/utils/nsview.py Show resolved Hide resolved
spyder/plugins/variableexplorer/widgets/main_widget.py Outdated Show resolved Hide resolved
@dalthviz dalthviz requested a review from ccordoba12 May 28, 2023 20:02
ccordoba12
ccordoba12 reviewed Jun 3, 2023
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsbautista for your work on this! It looks really nice!!

spyder/config/main.py Outdated Show resolved Hide resolved
spyder/config/main.py Outdated Show resolved Hide resolved
spyder/plugins/variableexplorer/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/variableexplorer/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/variableexplorer/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/plugins/variableexplorer/widgets/main_widget.py Show resolved Hide resolved
spyder/plugins/variableexplorer/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/plugins/variableexplorer/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/plugins/variableexplorer/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/widgets/collectionseditor.py Outdated Show resolved Hide resolved
@dalthviz dalthviz mentioned this pull request Jun 5, 2023
Closed
6 tasks
jsbautista and others added 2 commits June 13, 2023 14:38
@jsbautista
Merge branch 'master' into VariableExplorerIssues
f6ca198
@jsbautista
git subrepo pull --remote=https://github.com/jsbautista/spyder-kernel…
b1fba82 
…s.git --branch=variableExplorerKernels --update --force external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "db201a8aa"
upstream:
  origin:   "https://github.com/jsbautista/spyder-kernels.git"
  branch:   "variableExplorerKernels"
  commit:   "db201a8aa"
git-subrepo:
  version:  "0.4.6"
  origin:   "???"
  commit:   "???"
@dalthviz dalthviz mentioned this pull request Jun 13, 2023
Merged
jsbautista and others added 15 commits June 19, 2023 10:56
@jsbautista
Merge branch 'master' into VariableExplorerIssues
4028882
@jsbautista
git subrepo pull --remote=https://github.com/jsbautista/spyder-kernel…
d669a1a 
…s.git --branch=variableExplorerKernels --update --force external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "fd7a942a4"
upstream:
  origin:   "https://github.com/jsbautista/spyder-kernels.git"
  branch:   "variableExplorerKernels"
  commit:   "fd7a942a4"
git-subrepo:
  version:  "0.4.6"
  origin:   "???"
  commit:   "???"
@jsbautista
Merge branch 'VariableExplorerIssues' of https://github.com/jsbautist…
d71a5a1 
…a/spyder into VariableExplorerIssues
@jsbautista
Apply suggestions
429c61a
@jsbautista
Merge branch 'master' into VariableExplorerIssues
2f08bb1
@jsbautista
Merge branch 'master' into VariableExplorerIssues
e85910a
@jsbautista
Merge branch 'master' into VariableExplorerIssues
0d2e4ca
@jsbautista
Apply suggestions
079132d
@jsbautista
Merge branch 'VariableExplorerIssues' of https://github.com/jsbautist…
cb27172 
…a/spyder into VariableExplorerIssues
@jsbautista
Apply suggestions
8054316
@jsbautista
Apply suggestions
ea6243a
@jsbautista
Apply suggestions
b005727
@jsbautista
Apply suggestions
c1703d0
@jsbautista
Apply suggestions
cd1f439
@jsbautista
Apply suggestions
4952a49
@jsbautista jsbautista requested a review from dalthviz July 11, 2023 00:16
dalthviz
dalthviz reviewed Jul 11, 2023
View reviewed changes
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsbautista for the work here! I left a suggestion for the comment regarding the mouse cursor change which seems that was missing. Also, we need to wait for spyder-ide/spyder-kernels#460 to be merged so we can update the spyder-kernels subrepo again to the main repo. But, besides that this LGTM 👍

spyder/widgets/collectionseditor.py Outdated Show resolved Hide resolved
jsbautista and others added 2 commits July 11, 2023 19:06
@jsbautista @dalthviz
Update spyder/widgets/collectionseditor.py
ae04a3c 
Co-authored-by: Daniel Althviz Moré <d.althviz10@uniandes.edu.co>
@dalthviz
git subrepo pull --remote=https://github.com/spyder-ide/spyder-kernel…
dd82da9 
…s.git --branch=master --update --force external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "838f55d83"
upstream:
  origin:   "https://github.com/spyder-ide/spyder-kernels.git"
  branch:   "master"
  commit:   "838f55d83"
git-subrepo:
  version:  "0.4.3"
  origin:   "???"
  commit:   "???"
@dalthviz dalthviz requested a review from ccordoba12 July 12, 2023 21:32
ccordoba12
ccordoba12 reviewed Jul 12, 2023
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last small comments for you @jsbautista and @dalthviz, then this should be ready.

spyder/plugins/variableexplorer/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/variableexplorer/widgets/main_widget.py Show resolved Hide resolved
spyder/plugins/variableexplorer/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/plugins/variableexplorer/plugin.py Outdated Show resolved Hide resolved
ccordoba12
ccordoba12 approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsbautista and @dalthviz for your work on this!

@ccordoba12 ccordoba12 merged commit cf35639 into spyder-ide:master Jul 14, 2023
22 checks passed
@jitseniesen jitseniesen mentioned this pull request Jul 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalthviz dalthviz dalthviz left review comments

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@jsbautista jsbautista

Labels
component:Variable Explorer type:Enhancement User Experience (UX) User Interface (UI)
Projects
None yet
Milestone
v6.0alpha2
Development

Successfully merging this pull request may close these issues.

Variable Explorer issues
3 participants
@jsbautista @ccordoba12 @dalthviz