Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show files that are not Python files in the Outline Explorer #7982

Closed
jnsebgosselin opened this issue Oct 2, 2018 · 4 comments · Fixed by #7984
Closed

Show files that are not Python files in the Outline Explorer #7982

jnsebgosselin opened this issue Oct 2, 2018 · 4 comments · Fixed by #7984

Comments

@jnsebgosselin
Copy link
Member

Problem Description

As suggested by @CAM-Gerlach in #7968 (comment), text files that are not python files should be visible in the Outline Explorer.

This would be another step forward into making the Outline Explorer a viable proxy for a vertical tabbar for the Editor Stack.

text_file_in_oe

@ccordoba12

First thing first, do you agree with this?

Second, do you want to add this as an additional options in the context menu of the outline explorer or be the default behavior? If you ask me, I do not see the added benefit in adding another option for this.

@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented Oct 2, 2018

As a further comment, even when "Show all files" is enabled, the outline explorer is completely disabled when on a non-Python file so the user can't even switch to any Python file that is shown there. Should this be part of this issue, or a separate one?

Second, do you want to add this as an additional options in the context menu of the outline explorer or be the default behavior?

For what its worth, I agree with you here, since I really don't see the use case where "Show all files" is selected but the relatively modest additional space occupied by one-line entries for non Python files would be a significant hindrance. Furthermore, that entry does say "show all files", not *show all Python files" so its already implied and either the current behavior or wording be viewed as a bug.

@jnsebgosselin
Copy link
Member Author

As a further comment, even when "Show all files" is enabled, the outline explorer is completely disabled when on a non-Python file so the user can't even switch to any Python file that is shown there. Should this be part of this issue, or a separate one?

As part of this issue is alright I think. No matter what, this is going to be fixed as part of this enhancement proposal.

@CAM-Gerlach
Copy link
Member

Yeah, either part of this one or your Epic.

@ccordoba12
Copy link
Member

I agree with this and I don't see the need of adding another option for this.

In the future, we could add code folding for other file types and show that info in the outline explorer too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment