Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Sync Outline Explorer at startup and preserve the file order in the tabbar #7968

Merged

Conversation

jnsebgosselin
Copy link
Member

@jnsebgosselin jnsebgosselin commented Sep 30, 2018

Issue(s) Resolved

Fixes #7338

Pull Request Checklist

  • Added at least one unit test covering the changes, if at all possible
  • Described the changes and the motivation for them below
  • Included a screenshot, if this PR makes any visible changes to the UI

Description of Changes

Before :

image

After :

image

Developer Certificate of Origin Affirmation

By submitting this Pull Request or typing my name below, I affirm the
Developer Certificate of Origin
with respect to both the content of the contribution itself and this post,
and understand I am releasing it under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: Jean-Sébastien Gosselin

Add an option in the EditorStack to be able to add files at the start or
at the end of its tabbar.
First we load the last focused file and focus it, then we load the files
located before the last focused file in the tabbar, finally we load the
files located after the last focused file in the tabbar.
@pep8speaks
Copy link

Hello @jnsebgosselin! Thanks for submitting the PR.

Test that the file order is preserved during the Editor plugin setup and
that the current file correspond to the last focused file.
@ccordoba12
Copy link
Member

@jnsebgosselin, please fix the failure in Travis, it was introduced by a change done in this PR.

@jnsebgosselin
Copy link
Member Author

@jnsebgosselin, please fix the failure in Travis, it was introduced by a change done in this PR.

In AppVeyor you mean? The day we're going to drop Python 2 support is going to be celebration day.

@jnsebgosselin
Copy link
Member Author

setup_files

@CAM-Gerlach CAM-Gerlach changed the title PR: Synch Outline Explorer at startup and preserve the file order in the tabbar. PR: Sync Outline Explorer at startup and preserve the file order in the tabbar Oct 1, 2018
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jnsebgosselin!

@ccordoba12 ccordoba12 merged commit 0ab387e into spyder-ide:master Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants