Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Change color of matched brackets in some of the dark highlighting themes #12270

Merged
merged 1 commit into from Apr 11, 2020

Conversation

juanis2112
Copy link
Contributor

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Changed color of matched brackets in some of the dark highlighting themes to avoid the confusion with the font color of the brackets.

Screen Shot 2020-04-10 at 4 41 51 PM
Screen Shot 2020-04-10 at 4 41 29 PM
Screen Shot 2020-04-10 at 4 40 56 PM
Screen Shot 2020-04-10 at 4 40 32 PM
Screen Shot 2020-04-10 at 4 40 08 PM
Screen Shot 2020-04-10 at 4 39 45 PM
Screen Shot 2020-04-10 at 4 39 23 PM
Screen Shot 2020-04-10 at 4 38 58 PM

Issue(s) Resolved

Fixes #12154

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
Juanis2112

@ccordoba12 ccordoba12 changed the base branch from master to 4.x April 11, 2020 00:04
@ccordoba12 ccordoba12 added this to Release in v4.1.3 Apr 11, 2020
@ccordoba12 ccordoba12 added this to the Sprint April milestone Apr 11, 2020
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @juanis2112 for this!! We really needed to do this and I'm surprised no one brought it up before.

@ccordoba12
Copy link
Member

Note: The failures in our tests are not related to this and were already fixed.

@ccordoba12 ccordoba12 merged commit 6fc147d into spyder-ide:4.x Apr 11, 2020
ccordoba12 added a commit that referenced this pull request Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v4.1.3
Release
Development

Successfully merging this pull request may close these issues.

White brackets in the Obsidian theme
2 participants