Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Change icon and text of 'Lock Interface Action' when clicked #12527

Merged

Conversation

jnsebgosselin
Copy link
Member

@jnsebgosselin jnsebgosselin commented Apr 28, 2020

Description of Changes

Change the icon and text of the lock_interface_action according to the locked state of the panes and toolbars.

80288305-22674180-8705-11ea-966f-fb495cf53932

Issue(s) Resolved

Fixes #12488

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: Jean-Sébastien Gosselin

@goanpeca
Copy link
Member

Awesome :-) !

I think you need the latest 4.x to get those test fixes.

@jnsebgosselin
Copy link
Member Author

I think you need the latest 4.x to get those test fixes.

Ah no, I need to update the tests, I'm working on it.

goanpeca
goanpeca previously approved these changes Apr 30, 2020
Copy link
Member

@goanpeca goanpeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good @jnsebgosselin

Thanks!

@ccordoba12 ccordoba12 added this to the Sprint May milestone May 2, 2020
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would affect a video that was very difficult and time consuming for @juanis2112 to film, as part of her efforts to improve our documentation.

Therefore, I think we should leave this for Spyder 5. @jnsebgosselin, do you agree with that?

@jnsebgosselin
Copy link
Member Author

This will affect a video that was very difficult and time consuming for @juanis2112 to film, as part of her efforts to improve our documentation.

Therefore, I think we should leave this for Spyder 5. @jnsebgosselin, do you agree with that?

I have no problem with that, I'm running Spyder on master, so this won't affect me. I will rebase the branch.

@jnsebgosselin jnsebgosselin changed the base branch from 4.x to master May 3, 2020 20:21
@jnsebgosselin jnsebgosselin dismissed goanpeca’s stale review May 3, 2020 20:21

The base branch was changed.

@jnsebgosselin
Copy link
Member Author

mmmh, since there seems to be no conflict, do I need to rebase the branch anyway?

@jnsebgosselin
Copy link
Member Author

Ok I rebased anyway since it was pretty straightforward.

@ccordoba12 ccordoba12 added this to Release in v5.0alpha1 May 3, 2020
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for understanding @jnsebgosselin!

@ccordoba12 ccordoba12 merged commit d3c07d7 into spyder-ide:master May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v5.0alpha1
Release
Development

Successfully merging this pull request may close these issues.

An idea to improve the visual of the 'Lock panes and toolbars' action in the View menu
3 participants