New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Change icon and text of 'Lock Interface Action' when clicked #12527
PR: Change icon and text of 'Lock Interface Action' when clicked #12527
Conversation
Awesome :-) ! I think you need the latest 4.x to get those test fixes. |
Ah no, I need to update the tests, I'm working on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good @jnsebgosselin
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would affect a video that was very difficult and time consuming for @juanis2112 to film, as part of her efforts to improve our documentation.
Therefore, I think we should leave this for Spyder 5. @jnsebgosselin, do you agree with that?
I have no problem with that, I'm running Spyder on master, so this won't affect me. I will rebase the branch. |
mmmh, since there seems to be no conflict, do I need to rebase the branch anyway? |
Ok I rebased anyway since it was pretty straightforward. |
…p_lock_interface_action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for understanding @jnsebgosselin!
Description of Changes
Change the icon and text of the
lock_interface_action
according to the locked state of the panes and toolbars.Issue(s) Resolved
Fixes #12488
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: Jean-Sébastien Gosselin