Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add cookiecutter widget #12924

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

goanpeca
Copy link
Member

@goanpeca goanpeca commented Jun 2, 2020

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Add a generic cookiecutter parser so we can generate a UI on the fly with the correct widgets. This work will be used to enable cookicutter projects of different types:

  • Data science
  • Python Package
  • Spyder Plugin. (Example in image)

Screen Shot 2020-06-02 at 14 46 00

Issue(s) Resolved

Fixes #12938

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @goanpeca

@pep8speaks
Copy link

pep8speaks commented Jun 2, 2020

Hello @goanpeca! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-06-04 23:42:29 UTC

@goanpeca goanpeca force-pushed the enh/add-cookiecutter-widget branch 3 times, most recently from 6af3c79 to 2e1f570 Compare June 2, 2020 19:41
@goanpeca goanpeca changed the title WIP: Add cookiecutter widget PR: Add cookiecutter widget Jun 2, 2020
@goanpeca goanpeca force-pushed the enh/add-cookiecutter-widget branch 2 times, most recently from 4c2f544 to ae08d6d Compare June 2, 2020 19:59
@goanpeca goanpeca self-assigned this Jun 2, 2020
@goanpeca goanpeca added this to the Sprint June milestone Jun 2, 2020
@goanpeca goanpeca requested a review from ccordoba12 June 2, 2020 20:22
@goanpeca goanpeca marked this pull request as ready for review June 2, 2020 20:22
@goanpeca goanpeca force-pushed the enh/add-cookiecutter-widget branch from ae08d6d to 752cb75 Compare June 3, 2020 13:56
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goanpeca, this looks really good, thanks! I left a small review for you.

.github/scripts/install.sh Outdated Show resolved Hide resolved
spyder/plugins/projects/widgets/qcookiecutter.py Outdated Show resolved Hide resolved
spyder/plugins/projects/widgets/qcookiecutter.py Outdated Show resolved Hide resolved
@ccordoba12 ccordoba12 added this to Release in v5.0alpha1 Jun 3, 2020
@goanpeca goanpeca force-pushed the enh/add-cookiecutter-widget branch 2 times, most recently from b2f3f69 to 1ea0df7 Compare June 4, 2020 23:16
@goanpeca goanpeca requested a review from ccordoba12 June 4, 2020 23:16
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You left the line that installs cookiecutter from pip, so we can't be sure that the conda installation is working as expected.

Besides, please change the line endings of qcookiecutter.py to LF.

.github/scripts/install.sh Outdated Show resolved Hide resolved
spyder/plugins/projects/utils/cookie.py Show resolved Hide resolved
spyder/plugins/projects/widgets/qcookiecutter.py Outdated Show resolved Hide resolved
spyder/plugins/projects/widgets/qcookiecutter.py Outdated Show resolved Hide resolved
@goanpeca goanpeca force-pushed the enh/add-cookiecutter-widget branch from 1ea0df7 to e7f649b Compare June 4, 2020 23:42
@goanpeca
Copy link
Member Author

goanpeca commented Jun 4, 2020

You left the line that installs cookiecutter from pip, so we can't be sure that the conda installation is working as expected.

Fixed

Besides, please change the line endings of qcookiecutter.py to LF.

Fixed @ccordoba12

@goanpeca goanpeca requested a review from ccordoba12 June 4, 2020 23:43
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @goanpeca! Really cool addition!

@ccordoba12 ccordoba12 merged commit 2135228 into spyder-ide:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.0alpha1
Release
Development

Successfully merging this pull request may close these issues.

Add cookicutter handling and UI generation
3 participants