Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Find internal plugins in plugin module for Spyder installs #13400

Merged

Conversation

goanpeca
Copy link
Member

@goanpeca goanpeca commented Jul 27, 2020

Description of Changes

Issue(s) Resolved

  • This PR correctly finds internal plugins by checking in the spyder.plugins folder for installs running outside the normal spyder tests environment. This is needed to run Spyder with other plugins like the ATE one
  • PLUGIN_CLASS is replaced with PLUGIN_CLASSES as one plugin folder could potentially expose more than 1 plugin. Now that entry points are the way to expose plugins, this PLUGIN_CLASS is no longer needed for external plugins.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @goanpeca

@goanpeca goanpeca self-assigned this Jul 27, 2020
@pep8speaks
Copy link

pep8speaks commented Jul 27, 2020

Hello @goanpeca! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-07-27 20:02:44 UTC

@goanpeca goanpeca force-pushed the fix/internal-plugs-for-ext-tests branch 2 times, most recently from b295791 to 28c2c3b Compare July 27, 2020 19:46
@goanpeca goanpeca force-pushed the fix/internal-plugs-for-ext-tests branch from 28c2c3b to 35a5866 Compare July 27, 2020 20:02
@goanpeca goanpeca marked this pull request as ready for review July 27, 2020 20:32
@goanpeca goanpeca requested a review from ccordoba12 July 27, 2020 20:32
@goanpeca
Copy link
Member Author

@nerohmot, once this is merged, the tests against the Spyder application in Semi-ATE/Semi-ATE#10 can pass.

@nerohmot
Copy link

👍 @ccordoba12 When this PR is in, we can test Semi-ATE against spyder! 🎉

@ccordoba12 ccordoba12 changed the title PR: Find internal plugins in plugin module for spyder installs PR: Find internal plugins in plugin module for Spyder installs Jul 29, 2020
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @goanpeca!

@ccordoba12 ccordoba12 added this to the Sprint July milestone Jul 29, 2020
@ccordoba12 ccordoba12 added this to Release in v5.0alpha1 Jul 29, 2020
@ccordoba12 ccordoba12 merged commit 3e46b16 into spyder-ide:master Jul 29, 2020
@ccordoba12
Copy link
Member

When this PR is in, we can test Semi-ATE against spyder!

Great news @nerohmot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v5.0alpha1
Release
Development

Successfully merging this pull request may close these issues.

None yet

4 participants