PR: Restore submenu icon on internal console settings #13689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/show binder |
|
|
goanpeca
force-pushed
the
fix/restore-internal-console-icon
branch
from
514c16a
to
e1646c4
Compare
goanpeca
force-pushed
the
fix/restore-internal-console-icon
branch
from
e1646c4
to
d6462e3
Compare
|
/show binder |
|
|
|
@steff456, there's no need to generate a new Binder button after new commits have been pushed to a PR. Any button will load its latest commits. |
|
@ccordoba12, thanks for the info! I didn't knew that any button will work (: |
dalthviz
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
I think the Apple HIC guidelines do not recommend having Icons in SubMenus (they generally also advise against having submenus). So that is why this PR needs to override the default settings Qt uses for Mac with:
internal_settings_menu.menuAction().setIconVisibleInMenu(True)Issue(s) Resolved
Fixes #13683
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @goanpeca