Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix some issues with the profiler #13711

Merged
merged 1 commit into from
Dec 30, 2020

Conversation

goanpeca
Copy link
Member

@goanpeca goanpeca commented Sep 3, 2020

Description of Changes

  • Included a screenshot or animation (if affecting the UI, see Licecap)
  • The icons no longer have text next to them
  • In macOS icons don’t have tooltips.
  • The combobox in master is really small and it truncates the whole path of the file.

In macOS when I hit the option to expand all, the last entry is not visible even in the bottom of the scrollbar

I cannot reproduce this, see GIF

profiler

Issue(s) Resolved

Fixes #13698

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @goanpeca

Copy link
Contributor

@juanis2112 juanis2112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @goanpeca. Can you also please remove the text next to the browse icon? It wasn't originally in 4.x so I think for now it should be removed.

Finally I also noticed that the "Clear comparison" is available by default and in 4.x it is only available when there is actually some diff loaded which I think makes more sense. Can you fix this too?

@dalthviz
Copy link
Member

@ccordoba12 checking the failing test is unrelated to the changes done here. Seems like pandas 1.2.0 was released on December 26th and that is causing an error in the CollectionsEditor tests running under a pip installation). Besides that I think this is ready for review 👍

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @goanpeca and @dalthviz for your work on this one.

@ccordoba12 ccordoba12 dismissed juanis2112’s stale review December 30, 2020 22:56

Review was addressed

@ccordoba12 ccordoba12 merged commit ec3ac2b into spyder-ide:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profiler pane issues and details
4 participants