Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix typo in variable name #14319

Merged
merged 1 commit into from
Nov 29, 2020
Merged

PR: Fix typo in variable name #14319

merged 1 commit into from
Nov 29, 2020

Conversation

novaya
Copy link
Contributor

@novaya novaya commented Nov 26, 2020

Description of Changes

Fixed variable name

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

I think there was a typo in variable name, so I fixed it. Also logging put among third party libraries which is not correct

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@ccordoba12 ccordoba12 added this to the v5.0alpha3 milestone Nov 26, 2020
@ccordoba12 ccordoba12 changed the title Typo in variable name is fixed PR: Typo in variable name is fixed Nov 26, 2020
@ccordoba12 ccordoba12 self-assigned this Nov 29, 2020
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @novaya for your contribution!

Note: The failure on Windows is unrelated to this.

@ccordoba12 ccordoba12 changed the title PR: Typo in variable name is fixed PR: Fix typo in variable name Nov 29, 2020
@ccordoba12 ccordoba12 merged commit f56ce58 into spyder-ide:master Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants