-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Show a warning telling people how to get out of the pager (IPython console) #14418
Conversation
@isabela-pf, @juanis2112, I'd like to know your opinion about this feature. Is the idea of a pager grasped by you only by seeing the gif I posted above? That's basically the same experience our users will have. Unfortunately, I couldn't find a reference in the web we could link to to better describe this. |
Unsure the bar occupying the entire width is the best we can do. Few alternatives:
|
Thanks @OverLordGoldDragon, we like your first suggestion. We will make the text be "Press Q to exit pager" but autohiding it can be confusing if people miss the warning. Also the space on top is used when there are several tabs open so using that place for the warning might not be the best idea. |
- It can't be imported regularly because it loads some QtAwesome icons and that requires a QApplication running (which is created by the main_window fixture). - This allows us to run the Main Window tests independently again.
@steff456 suggested that we should only add a blue border around the pager message. This is how things look with that change: And this how they look with the old style and new text suggested by @OverLordGoldDragon: I think I prefer the second option because it seems easy to miss the warning with the first (as it looks part of the paged text). |
By seeing all the options I also prefer the blue background |
Description of Changes
The IPython console has a pager to show long texts in a separate widget to not overflow it with them. It was deactivated by default, but I removed that option with PR #14056 because I thought the pager was broken.
However, our users quickly found out that was not the case and @OverLordGoldDragon suggested we should add a warning to tell people how to get out of the pager. And that's what I've done in this PR.
Issue(s) Resolved
Fixes #14192.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: ccordoba12