Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Prevent double saving when running a file #14759

Merged
merged 4 commits into from
Feb 16, 2021

Conversation

andfoy
Copy link
Member

@andfoy andfoy commented Feb 15, 2021

Description of Changes

This PR fixes some autoformatting overlaps when a file is run in the iPython console due to duplicate calls to save when autoformatting on save is enabled

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #14653

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @andfoy

@andfoy andfoy added this to the v4.2.2 milestone Feb 15, 2021
@andfoy andfoy self-assigned this Feb 15, 2021
@pep8speaks
Copy link

pep8speaks commented Feb 15, 2021

Hello @andfoy! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-02-16 14:18:23 UTC

@andfoy andfoy changed the base branch from master to 4.x February 16, 2021 02:08
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andfoy for your help!

@ccordoba12 ccordoba12 merged commit 9325d0d into spyder-ide:4.x Feb 16, 2021
ccordoba12 added a commit that referenced this pull request Feb 16, 2021
@andfoy andfoy deleted the fix_double_save branch February 16, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible Black Autoformat Bug
3 participants