Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Several fixes to load external plugins #14782

Merged
merged 8 commits into from
Feb 21, 2021

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Feb 18, 2021

Description of Changes

This PR fixes several problems we discovered in 5.0 alpha4 when loading external plugins:

  • Add missing entry_points and fix init files for new plugins added in alpha3 and alpha4.
  • Fix solving list of required plugins for external plugins.
  • Fix adding third-party toolbars to the toolbars menu.
  • Make Preferences a required plugin for a couple of plugins that had it as optional.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@ccordoba12 ccordoba12 added this to the v5.0alpha5 milestone Feb 18, 2021
@ccordoba12 ccordoba12 self-assigned this Feb 18, 2021
@ccordoba12 ccordoba12 changed the title PR: Add missing entry_points and fix init files for new plugins PR: Add entry_points and fix init files for new plugins Feb 18, 2021
@ccordoba12 ccordoba12 changed the title PR: Add entry_points and fix init files for new plugins PR: Add missing entry_points and fix init files for new plugins Feb 18, 2021
@pep8speaks
Copy link

pep8speaks commented Feb 19, 2021

Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-02-21 01:11:20 UTC

@ccordoba12 ccordoba12 changed the title PR: Add missing entry_points and fix init files for new plugins PR: Several fixes to load external plugins Feb 19, 2021
@ccordoba12 ccordoba12 merged commit 03ba1b5 into spyder-ide:master Feb 21, 2021
@ccordoba12 ccordoba12 deleted the fix-loading-plugins branch February 21, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants