Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix location of newly created file and directory in Files #14831

Merged
merged 6 commits into from
Mar 15, 2021
Merged

PR: Fix location of newly created file and directory in Files #14831

merged 6 commits into from
Mar 15, 2021

Conversation

novaya
Copy link
Contributor

@novaya novaya commented Feb 28, 2021

Description of Changes

When we create new file or directory, location of the file or directory is one extra level above in the directory tree.

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
new

and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@ccordoba12 ccordoba12 requested a review from steff456 March 4, 2021 22:59
@ccordoba12 ccordoba12 added this to the v5.0alpha6 milestone Mar 4, 2021
Copy link
Member

@steff456 steff456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @novaya,

Thanks for submitting this PR! I'm seeing that all these pieces or code are repeated in different functions, so can you please create a small function with these instructions and then just call it in the methods you changed? With this change we will be able to maintain more effectively these snippets of code.

@novaya
Copy link
Contributor Author

novaya commented Mar 12, 2021

@steff456 Done

Copy link
Member

@steff456 steff456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! This looks ready for merge @ccordoba12

@ccordoba12 ccordoba12 changed the title Bug fix: location of newly created file and directory is not correct PR: Fix location of newly created file and directory Mar 15, 2021
@ccordoba12
Copy link
Member

Thanks for your help @novaya! This will be part of Spyder 5, to be released in a couple of weeks.

@ccordoba12 ccordoba12 changed the title PR: Fix location of newly created file and directory PR: Fix location of newly created file and directory in Files Mar 15, 2021
@ccordoba12 ccordoba12 merged commit 654b259 into spyder-ide:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants