Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add support for custom status bar widgets #14872

Merged
merged 4 commits into from
Mar 10, 2021

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Mar 4, 2021

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

This PR makes possible to add any kind of QWidget to the status bar. This is a shortcoming of our current API.

The screenshot below shows a QComboBox inserted in the status bar:

imagen

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@ccordoba12 ccordoba12 added this to the v5.0alpha6 milestone Mar 4, 2021
@ccordoba12 ccordoba12 self-assigned this Mar 4, 2021
@pep8speaks
Copy link

pep8speaks commented Mar 4, 2021

Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-03-06 17:46:01 UTC

@nerohmot
Copy link

nerohmot commented Mar 4, 2021

👍

…ing it

That will allow developers to have an icon, label and spinner for their
widgets, in case they need them.
@ccordoba12
Copy link
Member Author

Merging because we verified with @nerohmot that this is working as expected.

@ccordoba12 ccordoba12 merged commit 1dd460b into spyder-ide:master Mar 10, 2021
@ccordoba12 ccordoba12 deleted the custom-statusbar-widget branch March 10, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants