Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add external panels API to the editor #14874

Merged
merged 7 commits into from Mar 16, 2021

Conversation

steff456
Copy link
Member

@steff456 steff456 commented Mar 5, 2021

Description of Changes

This PR adds the possibility to add custom panels to the top, right, left, bottom and floating to the editor.

Example of a pane in the right:
image

Example of a pane in both left and right:
image

  • Expose the API in the EditorPlugin level
  • Create an example pane for tests
  • Cleanup the Panel Manager
  • Cleanup of the existing Panels

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: steff456

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @steff456 for this great addition!

spyder/api/panel.py Outdated Show resolved Hide resolved
spyder/api/panel.py Outdated Show resolved Hide resolved
spyder/api/panel.py Outdated Show resolved Hide resolved
spyder/api/panel.py Outdated Show resolved Hide resolved
spyder/api/panel.py Outdated Show resolved Hide resolved
spyder/plugins/editor/panels/scrollflag.py Outdated Show resolved Hide resolved
spyder/plugins/editor/widgets/editor.py Outdated Show resolved Hide resolved
spyder/plugins/editor/widgets/tests/test_panels.py Outdated Show resolved Hide resolved
spyder/plugins/editor/widgets/tests/test_panels.py Outdated Show resolved Hide resolved
spyder/plugins/editor/widgets/tests/test_panels.py Outdated Show resolved Hide resolved
@ccordoba12 ccordoba12 added this to the v5.0alpha6 milestone Mar 16, 2021
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks @steff456!

@ccordoba12 ccordoba12 changed the title PR: Add external panels API to the editor plugin PR: Add external panels API to the editor Mar 16, 2021
@ccordoba12 ccordoba12 merged commit ebacb1f into spyder-ide:master Mar 16, 2021
@steff456 steff456 deleted the add-editor-panes-api branch March 22, 2021 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants