Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add missing "self" argument in a method #14942

Merged
merged 1 commit into from Mar 17, 2021
Merged

PR: Add missing "self" argument in a method #14942

merged 1 commit into from Mar 17, 2021

Conversation

novaya
Copy link
Contributor

@novaya novaya commented Mar 17, 2021

Description of Changes

Added missing "self" argument

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@ccordoba12 ccordoba12 added this to the v5.0alpha6 milestone Mar 17, 2021
@ccordoba12 ccordoba12 changed the title Missing "self" argument PR: Add missing "self" argument in a method Mar 17, 2021
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks @novaya!

Note: The failure in our tests is unrelated to this.

@ccordoba12 ccordoba12 merged commit 1367d42 into spyder-ide:master Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants