Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Migrate the Outline Explorer to the new API #14998

Merged
merged 17 commits into from
Mar 27, 2021
Merged

PR: Migrate the Outline Explorer to the new API #14998

merged 17 commits into from
Mar 27, 2021

Conversation

andfoy
Copy link
Member

@andfoy andfoy commented Mar 24, 2021

Description of Changes

This PR migrates the outline explorer plugin to use the Spyder 5 API.

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @andfoy

@andfoy andfoy added this to the v5.0beta1 milestone Mar 24, 2021
@andfoy andfoy self-assigned this Mar 24, 2021
@andfoy andfoy marked this pull request as ready for review March 24, 2021 23:55
@andfoy andfoy changed the title [WIP] PR: Migrate the Outline Explorer to the new API PR: Migrate the Outline Explorer to the new API Mar 24, 2021
@andfoy andfoy requested a review from ccordoba12 March 25, 2021 00:25
ccordoba12
ccordoba12 reviewed Mar 25, 2021
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andfoy! This looks pretty good!

spyder/plugins/editor/widgets/editor.py Outdated Show resolved Hide resolved
spyder/plugins/outlineexplorer/widgets.py Outdated Show resolved Hide resolved
spyder/plugins/outlineexplorer/widgets.py Outdated Show resolved Hide resolved
spyder/plugins/outlineexplorer/widgets.py Outdated Show resolved Hide resolved
spyder/plugins/outlineexplorer/widgets.py Outdated Show resolved Hide resolved
spyder/plugins/outlineexplorer/widgets.py Show resolved Hide resolved
spyder/plugins/outlineexplorer/widgets.py Show resolved Hide resolved
spyder/plugins/outlineexplorer/widgets.py Outdated Show resolved Hide resolved
ccordoba12
ccordoba12 approved these changes Mar 27, 2021
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks @andfoy!

@ccordoba12 ccordoba12 merged commit 4467a81 into spyder-ide:master Mar 27, 2021
@andfoy andfoy deleted the migrate_outline_explorer branch March 27, 2021 17:21
@andfoy andfoy mentioned this pull request Apr 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@andfoy andfoy

Labels
None yet
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andfoy @ccordoba12