Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Use qdarkstyle subrepo in macOS app #15054

Merged
merged 3 commits into from
Mar 30, 2021

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Mar 30, 2021

Description of Changes

Use the qdarkstyle subrepo on pull requests in the pipeline build of the macOS application.

Issue(s) Resolved

Fixes #15053

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
@mrclary

@ccordoba12 ccordoba12 changed the title Fix macos app qdarkstyle PR: Use qdarkstyle subrepo in macOS app Mar 30, 2021
@ccordoba12 ccordoba12 added this to the v5.0.0 milestone Mar 30, 2021
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrclary for your help with this!

@ccordoba12 ccordoba12 merged commit 4ff0373 into spyder-ide:master Mar 30, 2021
@mrclary
Copy link
Contributor Author

mrclary commented Mar 30, 2021

@ccordoba12, thanks for fixing the typo.

@mrclary mrclary deleted the fix-macos-app-qdarkstyle branch March 30, 2021 16:12
@ccordoba12
Copy link
Member

Is the app working well for you? Unfortunately we don't have much time to test it before Thursday (the day of the final release), so it'd be great if you could let us know about that.

@mrclary
Copy link
Contributor Author

mrclary commented Mar 30, 2021

I've only been doing spot checking so far (#15053 and #14917). I'll start using the artifact from this PR. I'll post any new issues I discover, but otherwise assume that it is good.

@Xnac

This comment has been minimized.

@mrclary

This comment has been minimized.

@Xnac

This comment has been minimized.

@Xnac

This comment has been minimized.

@ccordoba12
Copy link
Member

ccordoba12 commented Apr 9, 2021

@Xnac, please don't post your comments on random PRs. Instead, please see issue #15113.

@spyder-ide spyder-ide locked and limited conversation to collaborators Apr 9, 2021
@ccordoba12
Copy link
Member

If you have problems with Spyder 5 and conda, please open a new issue instead.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qdarkstyle.colorsystem requirement missing
3 participants