Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix call to plugin method when saving a custom layout #15144

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Apr 6, 2021

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

The call to save the layout was missing the _plugin (since the logic is in the plugin)

Issue(s) Resolved

Fixes #15129

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

@dalthviz dalthviz added this to the v5.0.1 milestone Apr 6, 2021
@dalthviz dalthviz self-assigned this Apr 6, 2021
@dalthviz dalthviz requested a review from ccordoba12 April 6, 2021 17:57
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit b4b8eb1 into spyder-ide:5.x Apr 6, 2021
ccordoba12 added a commit that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants