Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Pin pyls-spyder version whilst pyls-black is migrated to pylsp #15468

Merged
merged 2 commits into from
Apr 30, 2021

Conversation

andfoy
Copy link
Member

@andfoy andfoy commented Apr 29, 2021

Description of Changes

This PR pins the required version of pyls-spyder to 0.3.2, which is the last version of pyls-spyder that was compatible with pyls.

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @andfoy

@andfoy andfoy added this to the v5.0.2 milestone Apr 29, 2021
@andfoy andfoy self-assigned this Apr 29, 2021
ccordoba12
ccordoba12 previously approved these changes Apr 30, 2021
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andfoy!

@ccordoba12 ccordoba12 changed the base branch from master to 5.x April 30, 2021 17:30
@ccordoba12 ccordoba12 dismissed their stale review April 30, 2021 17:30

The base branch was changed.

@ccordoba12 ccordoba12 merged commit e0b9739 into spyder-ide:5.x Apr 30, 2021
ccordoba12 added a commit that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants