Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Use community-based python-lsp-server instead of Palantir's python-language-server #15657

Merged
merged 29 commits into from
Jun 15, 2021

Conversation

andfoy
Copy link
Member

@andfoy andfoy commented May 19, 2021

Description of Changes

This PR migrates Spyder to use the community maintained python-lsp-server instead of Palantir's python-language-server, which stopped being maintained at the end of last year. This PR also updates the versions of pyls-spyder and replaces pyls-black by python-lsp-black.

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @andfoy

…external-deps/python-lsp-server

subrepo:
  subdir:   "external-deps/python-lsp-server"
  merged:   "22a746e5e"
upstream:
  origin:   "https://github.com/python-lsp/python-lsp-server.git"
  branch:   "develop"
  commit:   "22a746e5e"
git-subrepo:
  version:  "0.4.3"
  origin:   "git@github.com:ingydotnet/git-subrepo.git"
  commit:   "2f68596"
@andfoy andfoy added this to the v5.1.0 milestone May 19, 2021
@andfoy andfoy self-assigned this May 19, 2021
@pep8speaks

This comment has been minimized.

@andfoy andfoy requested a review from ccordoba12 May 20, 2021 18:02
@ccordoba12 ccordoba12 modified the milestones: v5.0.4, v5.1.0 May 24, 2021
ccordoba12
ccordoba12 previously approved these changes Jun 15, 2021
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here, thanks @andfoy!

@ccordoba12 ccordoba12 changed the base branch from master to 5.x June 15, 2021 22:05
@ccordoba12 ccordoba12 dismissed their stale review June 15, 2021 22:05

The base branch was changed.

@ccordoba12 ccordoba12 merged commit 8f344d6 into spyder-ide:5.x Jun 15, 2021
ccordoba12 added a commit that referenced this pull request Jun 15, 2021
@andfoy andfoy deleted the use_python_lsp_server branch June 15, 2021 22:30
@ccordoba12
Copy link
Member

@spyder-ide/core-developers, @spyder-ide/junior-developers, after this PR you need to install our new, community supported Python language server, called python-lsp-server, pyls-spyder 0.4.0 and python-lsp-black.

I recommend you to use Conda-forge these days because the defaults channel is usually outdated and has problems. If you're already using it, please run the following commands:

conda remove -c conda-forge python-language-server
conda install -c conda-forge pyls-spyder=0.4.0 python-lsp-black

If you're using pip, please run

pip uninstall python-language-server
pip install -U pyls-spyder python-lsp-black

Sorry for the disruption in your workflows. @andfoy and I have been working on this for the last three months because I lost maintainer permissions in the previous language server and we decided that the best moving forward was to fork it and maintain it in an organization of our own with other interested developers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants