Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Initial reorganizations of IPython Console actions for the mainmenu #15687

Merged
merged 4 commits into from
May 27, 2021

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented May 24, 2021

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Move mainmenu actions registration for IPython Console inside the plugin

Issue(s) Resolved

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

@dalthviz dalthviz self-assigned this May 24, 2021
@ccordoba12 ccordoba12 modified the milestones: v5.1.0, v5.0.4 May 24, 2021
@dalthviz dalthviz changed the title [WIP] PR: Initial reorganizations of IPython Console actions for the mainmenu PR: Initial reorganizations of IPython Console actions for the mainmenu May 25, 2021
@dalthviz dalthviz requested a review from ccordoba12 May 25, 2021 17:10
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small review for you @dalthviz, otherwise looks good to me.

spyder/plugins/ipythonconsole/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/plugin.py Outdated Show resolved Hide resolved
@ccordoba12 ccordoba12 modified the milestones: v5.1.0, v5.0.4 May 26, 2021
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants