Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix error in link to css files (Online Help) #15864

Merged
merged 1 commit into from
Jun 21, 2021
Merged

PR: Fix error in link to css files (Online Help) #15864

merged 1 commit into from
Jun 21, 2021

Conversation

Virinas-code
Copy link
Contributor

@Virinas-code Virinas-code commented Jun 14, 2021

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

image

Just use a absolute URL for style sheets.
Can't test new code because of dependencies problems.

Issue(s) Resolved

Fixes #15847

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
@Virinas-code

@ccordoba12 ccordoba12 changed the title Update pydoc_patch.py PR: Fix error in link to css files (Online Help) Jun 14, 2021
@ccordoba12
Copy link
Member

Hey @Virinas-code, thanks a lot for your help! Did you test this change by applying it to the current Spyder installation?

@Virinas-code
Copy link
Contributor Author

I can't test it because i've got dependencies problems.

@ccordoba12
Copy link
Member

Yeah, I read that part in your first message. But do you have problems with running Spyder from git? Or with your locally installed Spyder?

@Virinas-code
Copy link
Contributor Author

Yeah, I read that part in your first message. But do you have problems with running Spyder from git? Or with your locally installed Spyder?

When I use git it can't install pyflakes version.
I use pip for my spyder.

@Virinas-code
Copy link
Contributor Author

error: pycodestyle 2.6.0 is installed but pycodestyle>=2.7.0 is required by {'autopep8'}

@Virinas-code
Copy link
Contributor Author

But :

 root  /  opt  spyder  pycodestyle --version
2.7.0
 root  /  opt  spyder  

@ccordoba12
Copy link
Member

Ok, could apply the patch then to your installed Spyder to see if it works?

@Virinas-code
Copy link
Contributor Author

Ok, could apply the patch then to your installed Spyder to see if it works?

I'm trying...

@Virinas-code
Copy link
Contributor Author

Yes it fix bug !

@Virinas-code
Copy link
Contributor Author

I've got the error without the patch, but no errors with the patch.

@ccordoba12 ccordoba12 changed the base branch from master to 5.x June 20, 2021 21:00
@ccordoba12 ccordoba12 added this to the v5.1.0 milestone Jun 20, 2021
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @Virinas-code for your contribution!

@ccordoba12 ccordoba12 merged commit 012b06f into spyder-ide:5.x Jun 21, 2021
ccordoba12 added a commit that referenced this pull request Jun 21, 2021
@ccordoba12
Copy link
Member

This will be part of our 5.1.0 version, to be released at the end of July.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileNotFoundError in Online help
2 participants