PR: Make IPython Console widgets and other elements to use the SpyderConfigurationAccessor #15887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthviz
force-pushed
the
ipyconsole_widgets
branch
from
1c8192d
to
f048570
Compare
ccordoba12
reviewed
Jun 17, 2021
dalthviz
changed the title
ccordoba12
reviewed
Jun 23, 2021
There was a problem hiding this comment.
This looks pretty good, thanks @dalthviz! I only left a tiny suggestion for you.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
ccordoba12
added a commit
that referenced
this pull request
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Move IPython Console widgets and other components to use the
SpyderConfigurationAccessorinstead of usingCONFdirectlyIssue(s) Resolved
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: dalthviz