Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add border around WebView widgets #15916

Merged
merged 5 commits into from
Jun 23, 2021

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Jun 22, 2021

Description of Changes

We were not drawing borders around WebView widgets such as the ones used in Help and Online Help.

Before

imagen

After

imagen

Other changes include:

  • Paint the border with an accent color when it has focus.
  • Fix layout for Online Help main widget.
  • Prevent to give focus to WebView widgets only for old PyQt versions (5.12+ doesn't have this problem).
  • Make tests run for any 5.* branch.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@ccordoba12 ccordoba12 added this to the v5.0.5 milestone Jun 22, 2021
@ccordoba12 ccordoba12 self-assigned this Jun 22, 2021
@ccordoba12 ccordoba12 merged commit 6326629 into spyder-ide:5.x.x Jun 23, 2021
@ccordoba12 ccordoba12 deleted the fix-webview-border branch June 23, 2021 15:51
ccordoba12 added a commit that referenced this pull request Jun 23, 2021
ccordoba12 added a commit that referenced this pull request Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant