Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Move create_application and create_window to utils (Main window) #16041

Merged
merged 4 commits into from
Jul 19, 2021

Conversation

ccordoba12
Copy link
Member

Description of Changes

This is a small refactoring that moves those self-contained functions out of mainwindow.py

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@ccordoba12 ccordoba12 added this to the v5.1.0 milestone Jul 19, 2021
@pep8speaks
Copy link

pep8speaks commented Jul 19, 2021

Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 52:1: E402 module level import not at top of file
Line 72:1: E402 module level import not at top of file

Comment last updated at 2021-07-19 05:04:03 UTC

@ccordoba12 ccordoba12 self-assigned this Jul 19, 2021
@ccordoba12 ccordoba12 merged commit 08f5f1c into spyder-ide:5.x Jul 19, 2021
@ccordoba12 ccordoba12 deleted the move-app-utils branch July 19, 2021 16:35
ccordoba12 added a commit that referenced this pull request Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants