-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Use completionItem/resolve to improve completion performance #16057
PR: Use completionItem/resolve to improve completion performance #16057
Conversation
subrepo: subdir: "external-deps/python-lsp-server" merged: "1d7091b6b" upstream: origin: "https://github.com/python-lsp/python-lsp-server.git" branch: "develop" commit: "1d7091b6b" git-subrepo: version: "0.4.3" origin: "git@github.com:ingydotnet/git-subrepo.git" commit: "2f68596"
Hello @andfoy! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-07-22 00:41:36 UTC |
subrepo: subdir: "external-deps/python-lsp-server" merged: "58b229b52" upstream: origin: "https://github.com/python-lsp/python-lsp-server.git" branch: "develop" commit: "58b229b52" git-subrepo: version: "0.4.3" origin: "git@github.com:ingydotnet/git-subrepo.git" commit: "2f68596"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andfoy! This is a great improvement.
Description of Changes
This PR enables the support for the
completionItem/resolve
LSP call. This feature was added in python-lsp/python-lsp-server#25 in the python-lsp-serverIssue(s) Resolved
Fixes #15042
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @andfoy