Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Use completionItem/resolve to improve completion performance #16057

Merged
merged 3 commits into from
Jul 22, 2021

Conversation

andfoy
Copy link
Member

@andfoy andfoy commented Jul 21, 2021

Description of Changes

This PR enables the support for the completionItem/resolve LSP call. This feature was added in python-lsp/python-lsp-server#25 in the python-lsp-server

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Peek 21-07-2021 17-47

Issue(s) Resolved

Fixes #15042

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @andfoy

subrepo:
  subdir:   "external-deps/python-lsp-server"
  merged:   "1d7091b6b"
upstream:
  origin:   "https://github.com/python-lsp/python-lsp-server.git"
  branch:   "develop"
  commit:   "1d7091b6b"
git-subrepo:
  version:  "0.4.3"
  origin:   "git@github.com:ingydotnet/git-subrepo.git"
  commit:   "2f68596"
@pep8speaks
Copy link

pep8speaks commented Jul 21, 2021

Hello @andfoy! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 56:80: E501 line too long (83 > 79 characters)

Line 76:80: E501 line too long (89 > 79 characters)

Line 33:80: E501 line too long (80 > 79 characters)

Line 110:80: E501 line too long (93 > 79 characters)
Line 160:80: E501 line too long (84 > 79 characters)
Line 173:80: E501 line too long (83 > 79 characters)
Line 252:80: E501 line too long (97 > 79 characters)
Line 283:80: E501 line too long (80 > 79 characters)
Line 310:80: E501 line too long (82 > 79 characters)

Line 33:80: E501 line too long (85 > 79 characters)
Line 86:80: E501 line too long (98 > 79 characters)

Line 165:80: E501 line too long (115 > 79 characters)
Line 203:80: E501 line too long (83 > 79 characters)
Line 269:80: E501 line too long (100 > 79 characters)

Line 11:80: E501 line too long (80 > 79 characters)
Line 55:80: E501 line too long (80 > 79 characters)

Line 16:80: E501 line too long (109 > 79 characters)
Line 152:80: E501 line too long (89 > 79 characters)
Line 166:80: E501 line too long (82 > 79 characters)
Line 190:80: E501 line too long (82 > 79 characters)
Line 196:80: E501 line too long (89 > 79 characters)
Line 217:80: E501 line too long (89 > 79 characters)

Line 91:80: E501 line too long (87 > 79 characters)
Line 113:80: E501 line too long (86 > 79 characters)
Line 147:80: E501 line too long (86 > 79 characters)

Line 77:80: E501 line too long (83 > 79 characters)

Comment last updated at 2021-07-22 00:41:36 UTC

subrepo:
  subdir:   "external-deps/python-lsp-server"
  merged:   "58b229b52"
upstream:
  origin:   "https://github.com/python-lsp/python-lsp-server.git"
  branch:   "develop"
  commit:   "58b229b52"
git-subrepo:
  version:  "0.4.3"
  origin:   "git@github.com:ingydotnet/git-subrepo.git"
  commit:   "2f68596"
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andfoy! This is a great improvement.

@ccordoba12 ccordoba12 merged commit 089f6a8 into spyder-ide:5.x Jul 22, 2021
ccordoba12 added a commit that referenced this pull request Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants