Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Make go-to-defintion and hover work for files when no project is active or outside of it (Completions) #16099

Merged
merged 2 commits into from
Jul 28, 2021

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Jul 28, 2021

Description of Changes

Issue(s) Resolved

Fixes #15400
Fixes #13358

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

…ordoba12/python-lsp-server.git external-deps/python-lsp-server

subrepo:
  subdir:   "external-deps/python-lsp-server"
  merged:   "a99d51c70"
upstream:
  origin:   "https://github.com/ccordoba12/python-lsp-server.git"
  branch:   "fix-goto-def"
  commit:   "a99d51c70"
git-subrepo:
  version:  "0.4.3"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "2f68596"
@ccordoba12 ccordoba12 added this to the v5.1.0 milestone Jul 28, 2021
@ccordoba12 ccordoba12 self-assigned this Jul 28, 2021
@pep8speaks
Copy link

pep8speaks commented Jul 28, 2021

Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 14:80: E501 line too long (85 > 79 characters)

Line 94:80: E501 line too long (98 > 79 characters)

Comment last updated at 2021-07-28 19:38:42 UTC

@ccordoba12 ccordoba12 changed the title PR: Make go-to-defintion and hover work for files when no project is active or outside it (Completions) PR: Make go-to-defintion and hover work for files when no project is active or outside of it (Completions) Jul 28, 2021
…lsp/python-lsp-server.git external-deps/python-lsp-server

subrepo:
  subdir:   "external-deps/python-lsp-server"
  merged:   "32bbc067f"
upstream:
  origin:   "https://github.com/python-lsp/python-lsp-server.git"
  branch:   "develop"
  commit:   "32bbc067f"
git-subrepo:
  version:  "0.4.3"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "2f68596"

[ci skip]
@ccordoba12 ccordoba12 merged commit 06e7929 into spyder-ide:5.x Jul 28, 2021
@ccordoba12 ccordoba12 deleted the fix-goto-def branch July 28, 2021 19:39
ccordoba12 added a commit that referenced this pull request Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants