Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Improve how we handle responses of completion item resolution (Editor) #16145

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Aug 4, 2021

Description of Changes

  • Now we pass on empty responses, instead of passing them to the completion widget.
  • We also catch the usual errors that can happen with any response.

Issue(s) Resolved

Fixes #16125

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@ccordoba12 ccordoba12 added this to the v5.1.1 milestone Aug 4, 2021
@ccordoba12 ccordoba12 self-assigned this Aug 4, 2021
@ccordoba12 ccordoba12 merged commit 4994d05 into spyder-ide:5.x Aug 4, 2021
@ccordoba12 ccordoba12 deleted the issue-16125 branch August 4, 2021 17:03
ccordoba12 added a commit that referenced this pull request Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant