Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add tests for external plugins using spyder-boilerplate #16170

Merged
merged 7 commits into from
Aug 7, 2021

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Aug 7, 2021

Description of Changes

  • Install spyder-boilerplate on CIs and run tests related to it only there.
  • Skip some flaky tests to improve running time in CIs.
  • Use spyder-boilerplate to test functionality related to external plugins.
  • Don't use pkg_resources to register completion provider entrypoints when running on CIs. That help us to test if they work when the package is installed.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@ccordoba12 ccordoba12 added this to the v5.1.2 milestone Aug 7, 2021
@ccordoba12 ccordoba12 self-assigned this Aug 7, 2021
@pep8speaks
Copy link

pep8speaks commented Aug 7, 2021

Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 31:80: E501 line too long (85 > 79 characters)

Line 42:5: E303 too many blank lines (2)

Comment last updated at 2021-08-07 21:28:43 UTC

@ccordoba12 ccordoba12 merged commit b3588fe into spyder-ide:5.x Aug 7, 2021
@ccordoba12 ccordoba12 deleted the check-external-plugins branch August 7, 2021 22:13
ccordoba12 added a commit that referenced this pull request Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants