Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: debugpy is not zip compatible (macOS app) #16337

Merged
merged 2 commits into from Sep 4, 2021

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Sep 2, 2021

Description of Changes

Ensured that debugpy is bundled outside zip folder in macOS application.

Issue(s) Resolved

Fixes #16336

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @mrclary

…a directory: '.../Spyder.app/Contents/Resources/lib/python39.zip/debugpy/_vendored'"
@ccordoba12 ccordoba12 added this to the v5.1.3 milestone Sep 2, 2021
@ccordoba12 ccordoba12 changed the base branch from master to 5.x September 2, 2021 17:26
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mrclary, thanks a lot for your prompt help! I left a small style suggestion for you, otherwise looks good to me.

installers/macOS/setup.py Outdated Show resolved Hide resolved
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrclary!

@ccordoba12 ccordoba12 merged commit ab542e5 into spyder-ide:5.x Sep 4, 2021
ccordoba12 added a commit that referenced this pull request Sep 4, 2021
@mrclary mrclary deleted the issue-16336-debugpy branch September 4, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5.1.2 Mac installer broken?
2 participants