-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Improve appearance of toolbar extension button #16375
PR: Improve appearance of toolbar extension button #16375
Conversation
Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-09-15 00:03:47 UTC |
/show binder |
Hooray! I'm very glad to see this happening, especially since I think it's a really big experience change. Especially if people make extensions that use the toolbars, which are already tight on space. A few points addressing questions we discussed when meeting:
Thanks for doing this! |
This was suggested in review.
cdcf085
to
0227bc3
Compare
Thanks @isabela-pf for the review! I made the changes you requested and updated the screenshot above. However, I still have to verify how this looks on Windows and macOS. I'll let you know when that's done. |
In mac the size of the widgets of the main toolbar 54x46 and in the plugin's toolbars the size is 42x42. You need to fix this. |
Description of Changes
Before
After
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12