Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Improve appearance of toolbar extension button #16375

Merged
merged 8 commits into from
Sep 15, 2021

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Sep 7, 2021

Description of Changes

  • The size and icon of that button were almost imperceptible. This PR aims to improve that.
  • Thanks to the new API, this fix will apply to both the main and pane toolbars as well.

Before

imagen

After

imagen

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@ccordoba12 ccordoba12 added this to the v5.2.0 milestone Sep 7, 2021
@ccordoba12 ccordoba12 self-assigned this Sep 7, 2021
@pep8speaks
Copy link

pep8speaks commented Sep 7, 2021

Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 268:80: E501 line too long (97 > 79 characters)

Comment last updated at 2021-09-15 00:03:47 UTC

@isabela-pf
Copy link
Collaborator

/show binder

@github-actions
Copy link

github-actions bot commented Sep 7, 2021

Binder 👈 Launch a Binder instance on this branch

@isabela-pf
Copy link
Collaborator

Hooray! I'm very glad to see this happening, especially since I think it's a really big experience change. Especially if people make extensions that use the toolbars, which are already tight on space.

A few points addressing questions we discussed when meeting:

  • Buttons need to have at least the minimum accessible clickable area. At that point, it's probably best to make it match the other buttons, too.
  • Since we need the minimum clickable area, the vertical dots (mdi-dots-vertical) won't really save space. I think mdi-dots-horizontal is the more familiar version of this icon and may be preferable to use.

Thanks for doing this!

@ccordoba12
Copy link
Member Author

ccordoba12 commented Sep 12, 2021

Thanks @isabela-pf for the review! I made the changes you requested and updated the screenshot above.

However, I still have to verify how this looks on Windows and macOS. I'll let you know when that's done.

@steff456
Copy link
Member

In mac the size of the widgets of the main toolbar 54x46 and in the plugin's toolbars the size is 42x42. You need to fix this.

@ccordoba12 ccordoba12 modified the milestones: v5.2.0, v5.1.5 Sep 14, 2021
@ccordoba12 ccordoba12 merged commit 3067a3d into spyder-ide:5.x Sep 15, 2021
@ccordoba12 ccordoba12 deleted the improve-toolbar-extbutton branch September 15, 2021 01:38
ccordoba12 added a commit that referenced this pull request Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants