PR: Add constraint for jupyter_client version on conda based test #16389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
Sep 9, 2021
There was a problem hiding this comment.
@dalthviz, now that I see our tests failing I recalled the problem with the approach you're trying so far. Since we have a test that checks our dependencies among setup.py, Binder, conda.txt and dependencies.py are in sync, you'd need to add this constraint to all of them.
But in this case that's not really necessary because we depend indirectly on jupyter-client (through Spyder-kernels). So the right thing to do is to add it to .github/scripts/install.sh.
ccordoba12
changed the title
dalthviz
force-pushed
the
fix_test_jc
branch
from
d837c5e
to
3524986
Compare
ccordoba12
added a commit
that referenced
this pull request
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
CI tests with conda failing due to
jupyter_client7.x being available in the conda main channelAffirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: dalthviz