PR: Read project config file using UTF-8 (Projects) #16522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAM-Gerlach
changed the title
CAM-Gerlach
reviewed
Oct 5, 2021
There was a problem hiding this comment.
LGTM @ccordoba12 . FYI though, this only affects non-ASCII characters in the file itself; it should have no effect on file paths (unless you're referring to those included as values in the file). Also, note that if the existing file was written out with extended ASCII (Latin-1, Windows-1252, etc) characters (as is possible, though unlikely, on Windows), attempting to read that file will fail. You have confirmed you're already writing it out as UTF-8, correct?
|
Thanks for the review @CAM-Gerlach! |
|
Thanks for all the work @ccordoba12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This allows to load that file when there are unicode characters in it.
Issue(s) Resolved
Fixes #15340
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12