Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix link to Spyder docs in connect to external kernel dialog #16540

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

CAM-Gerlach
Copy link
Member

Description of Changes

As helpfully spotted by @hyamanieu in spyder-ide/spyder-docs#297 , the URL to the external kernel docs in the Connect to kernel dialog is out of date and doesn't work. This PR fixes that. I also checked all the other URLs to the docs, and confirmed the rest are all up to date and working.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: CAM-Gerlach

@CAM-Gerlach
Copy link
Member Author

Note: @ccordoba12 when merging to master, you'll likely want to change the 5 in the link to current; the 5 makes sure it stays locked to the correct version of the docs even in old versions of Spyder, so the links don't suddenly break with changes in current.

@ccordoba12
Copy link
Member

when merging to master, you'll likely want to change the 5 in the link to current

Good point! Will take care of it.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CAM-Gerlach!

@ccordoba12 ccordoba12 merged commit 8fbb933 into spyder-ide:5.x Oct 6, 2021
ccordoba12 added a commit that referenced this pull request Oct 6, 2021
@CAM-Gerlach
Copy link
Member Author

Thanks @ccordoba12 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants