Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add missing argument to shortcut preferences #16787

Merged
merged 2 commits into from
Nov 11, 2021

Conversation

steff456
Copy link
Member

@steff456 steff456 commented Nov 9, 2021

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Add the missing argument, section that caused and error and made the users unable to change any shortcut in preferences.

Issue(s) Resolved

Fixes #16749

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: Steff456

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @steff456! This looks good to me.

Please merge with 5.x to see if our tests pass after that.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @steff456!

@ccordoba12 ccordoba12 merged commit 3ca8181 into spyder-ide:5.x Nov 11, 2021
ccordoba12 added a commit that referenced this pull request Nov 11, 2021
@steff456 steff456 deleted the fix_16749 branch November 12, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants