Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix some issues after the IPython Console migration #16831

Merged
merged 5 commits into from
Nov 17, 2021

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Nov 15, 2021

Description of Changes

  • Keep focus in the Editor after startup
  • Don't show restart dialog to apply preferences at startup (check restart preferences dialog validation)

Issue(s) Resolved

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

@dalthviz dalthviz added this to the v5.2.0 milestone Nov 15, 2021
@dalthviz dalthviz self-assigned this Nov 15, 2021
@dalthviz dalthviz changed the title [WIP] PR: Fix some issues after the IPython Console migration PR: Fix some issues after the IPython Console migration Nov 16, 2021
@ccordoba12
Copy link
Member

@dalthviz, now spyder/app/tests/test_mainwindow.py::test_get_help_editor is either failing or freezing in our pip slot (this has happened twice).

Could you debug and try to solve that problem? I don't know if it's related to this PR or not.

@pep8speaks
Copy link

pep8speaks commented Nov 16, 2021

Hello @dalthviz! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-11-17 17:48:21 UTC

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your work on this @dalthviz! It's working as expected.

I left a small comment, otherwise looks good to me.

spyder/plugins/ipythonconsole/widgets/main_widget.py Outdated Show resolved Hide resolved
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit 4e15ee0 into spyder-ide:5.x Nov 17, 2021
ccordoba12 added a commit that referenced this pull request Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants