Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Improve the "Create new project" dialog (Projects) #16847

Merged
merged 7 commits into from
Nov 17, 2021

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Nov 17, 2021

Description of Changes

  • Add message to explain users how to use that dialog.
  • Validate selected directories and show a message about why a project can't be created at a particular location.
  • Disable Create button when validation doesn't pass.
  • Make that pressing Enter selects Create when validation pass.
  • Make dialog to auto-resize when content is hidden.
  • Remove unnecessary empty space.

Before

image

After

image

Issue(s) Resolved

Fixes #16745.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@ccordoba12 ccordoba12 added this to the v5.2.0 milestone Nov 17, 2021
@ccordoba12 ccordoba12 self-assigned this Nov 17, 2021
@ccordoba12 ccordoba12 merged commit f3fe96c into spyder-ide:5.x Nov 17, 2021
@ccordoba12 ccordoba12 deleted the issue-16745 branch November 17, 2021 22:05
ccordoba12 added a commit that referenced this pull request Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant