PR: Filter 'This version of python seems to be incorrectly compiled...' pydev_log.critical message #16849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le client's show_kernel_error
|
@impact27, the message is filtered from display and from the installer test, but is still written to the stderr file. I think this is probably the appropriate behavior so that the stderr file, in principle, can still be inspected for debugging and the message is still filtered for duplication in |
|
Looks good to me |
This reverts commit 4fe4fe7.
|
@mrclary, don't worry about the failure in Linux. It's unrelated to this and I'll fix it in another PR. After that, I'll merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
With #14025 the critical logging message from
pydevdno longer causes the installer test to fail, but is still briefly displayed in the IPython console. This PR filters this message for both the installer test and IPython console display.Issue(s) Resolved
Fixes #16828
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @mrclary