Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Do not check for change on every keystroke #16925

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

impact27
Copy link
Contributor

@impact27 impact27 commented Dec 1, 2021

Description of Changes

I am not sure why it is necessery to check for the change status on every text change. Upless I am missing something this is not needed.

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@impact27 impact27 changed the base branch from master to 5.x December 1, 2021 17:02
@impact27 impact27 closed this Dec 1, 2021
@impact27 impact27 reopened this Dec 1, 2021
@ccordoba12 ccordoba12 added this to the v5.2.1 milestone Dec 1, 2021
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @impact27!

@ccordoba12 ccordoba12 merged commit 2562e0b into spyder-ide:5.x Dec 1, 2021
ccordoba12 added a commit that referenced this pull request Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants