PR: Override RichJupyterWidget._get_color() because we use a custom style (IPython console)

[bnavigator]

Description of Changes

• Wrote at least one-line docstrings (for any new functions)
• Added unit test(s) covering the changes (if testable)

• Included a screenshot or animation (if affecting the UI, see Licecap)

This is a follow-up on jupyter/qtconsole#512

before	This PR + jupyter/qtconsole#512 + ipython/ipython#13372

Issue(s) Resolved

Fixes #14895
Fixes last comments (non-sympy) in #3798

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: bnavigator

[pep8speaks]

Hello @bnavigator! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-02-14 00:21:23 UTC

[ccordoba12]

Thanks a lot for your help with this @bnavigator! It's great to have the right foreground color in equations for any library and not just Sympy.

Besides the tiny comment I left for you below, please also remove the calls to set_sympy_forecolor shown below because they are not necessary anymore.

spyder/spyder/plugins/ipythonconsole/widgets/shell.py

Lines 326 to 332 in a433076

	if not dark_color:
	# Needed to change the colors of tracebacks
	self.silent_execute("%colors linux")
	self.call_kernel().set_sympy_forecolor(background_color='dark')
	else:
	self.silent_execute("%colors lightbg")
	self.call_kernel().set_sympy_forecolor(background_color='light')

[bnavigator]

please also remove the calls to set_sympy_forecolor shown below because they are not necessary anymore.

Are you sure about this? Sympy uses its own set of printers and is not affected by the change for the QtConsole/IPython renderer of _repr_latex_() attributes.

With your suggested change:

[ccordoba12]

Are you sure about this?

I thought that call wasn't necessary anymore. Thanks a lot for checking that out!

[oscargus]

Note that SymPy behaves differently before and after calling init_printing(). Before calling init_printing the actual image is rendered by IPython (similar to the left hand side in the original figure), while after it is rendered by SymPy.

"%colors lightbg" is the flexible way to tell IPython what a good guess of foreground colors are when using its own rendering, see https://ipython.readthedocs.io/en/stable/config/details.html#terminal-colors

Edit: this was probably a bit off topic, but it is not always as straightforward to change the color directly.

[ccordoba12]

@bnavigator, some small suggestions to go with the ones I made in PR jupyter/qtconsole#512. The this should be ready.

[ccordoba12]

@bnavigator, thanks for your help in all related repos to solve this issue. It's a terrific improvement!

Note: The failure in our tests is unrelated to this change.