Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Improve message about missing spyder-kernels (IPython console) #17033

Merged
merged 2 commits into from
Dec 17, 2021

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Dec 16, 2021

Description of Changes

  • Now we show the path of the interpreter that doesn't have the right version of spyder-kernels in the message.
  • This way users will know where they have to update/install spyder-kernels for the IPyhotn console to work again.

Before

imagen

After

imagen

Issue(s) Resolved

Fixes #17027

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

- Now we show the path of the interpreter that doesn't have the right
spyder-kernels version in the message.
- This way users will know where they have to update/install spyder-kernels
for the IPyhotn console to work again.
@ccordoba12 ccordoba12 added this to the v5.2.2 milestone Dec 16, 2021
@ccordoba12 ccordoba12 self-assigned this Dec 16, 2021
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ccordoba12 ! I left a comment regarding the formatting for the indents (another option using the pre tag) but this LGTM 👍

spyder/plugins/ipythonconsole/widgets/main_widget.py Outdated Show resolved Hide resolved
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ccordoba12 ! LGTM 👍

@dalthviz dalthviz merged commit 95f159d into spyder-ide:5.x Dec 17, 2021
dalthviz added a commit that referenced this pull request Dec 17, 2021
@ccordoba12 ccordoba12 deleted the issue-17027 branch December 17, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants