PR: Fix "Show in external file explorer" for non-existing file (Windows) #17064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The action can be found in the menu of the editor’s tabbar. It did not work under Windows for newly created files which haven’t beened saved yet.
dalthviz
changed the title
|
Hey @rear1019, thanks for your help with this! You said:
Do you plan to check, and if failing fix, that as part of this pull request? |
Just confirmed that the patch also fixes the action in the right-click menu of editor’s tabs (the button in the right corner of the tabbar displays the same menu object). |
|
Great! Thanks for confirming that @rear1019! |
ccordoba12
approved these changes
Dec 23, 2021
ccordoba12
changed the title
ccordoba12
added a commit
that referenced
this pull request
Dec 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
See commit message for details.
PS: The same action in right-click menu of editor’s tabs is possibly affected as well.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct:
rear1019