PR: Fix traitlets deprecation warning #17076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
Dec 22, 2021
There was a problem hiding this comment.
Thanks for your help with this @juliangilbey! I left a minor comment, otherwise looks good to me.
setup.py
Outdated
| @@ -241,6 +241,7 @@ def run(self): | |||
| 'spyder-kernels>=2.2.0,<2.3.0', | |||
| 'textdistance>=4.2.0', | |||
| 'three-merge>=0.1.1', | |||
| 'traitlets>=4.1', | |||
There was a problem hiding this comment.
Suggested change
| 'traitlets>=4.1', |
trailets is a transitive dependency, so we don't need to depend on it directly:
spyder -> spyder-kernels -> ipykernel -> traitlets
There was a problem hiding this comment.
This is true, though the remainder of the patch does explicitly import it. I guess it's a matter of style to a great extent; this explicit listing just makes the version requirements explicit, though ipykernel does that anyway. I'm not particularly bothered either way; happy to make that change or let you do it.
There was a problem hiding this comment.
Please make it. We already have a lot of dependencies to add one more for such a simple change.
ccordoba12
approved these changes
Dec 23, 2021
ccordoba12
changed the title
ccordoba12
added a commit
that referenced
this pull request
Dec 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixed the traitlets DeprecationWarning raised by
spyder/plugins/ipythonconsole/tests/test_ipythonconsole.py::test_banners. The unit test should no longer raise a warning after this change.Issue(s) Resolved
Fixes #14534 with thanks to @dalthviz
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin,
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @juliangilbey