PR: Put user provided paths at the front of sys.path #17077
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @mrclary! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2022-01-21 20:15:29 UTC |
mrclary
force-pushed
the
pypath-priority
branch
from
4029c28
to
936cc11
Compare
…erting at position 1.
Was the intention to always have the current working directory ('') at position 0? Because it was not at position 0.
…ments/Python/python-lsp-server external-deps/python-lsp-server/ subrepo: subdir: "external-deps/python-lsp-server" merged: "34ccad2f0" upstream: origin: "/Users/rclary/Documents/Python/python-lsp-server" branch: "pypath-priority" commit: "34ccad2f0" git-subrepo: version: "0.4.3" origin: "???" commit: "???"
…ments/Python/spyder-kernels external-deps/spyder-kernels/ subrepo: subdir: "external-deps/spyder-kernels" merged: "9042046e8" upstream: origin: "/Users/rclary/Documents/Python/spyder-kernels" branch: "pypath-priority" commit: "9042046e8" git-subrepo: version: "0.4.3" origin: "???" commit: "???"
mrclary
force-pushed
the
pypath-priority
branch
from
936cc11
to
cec0b53
Compare
|
Closing in favor of #18308 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Put user provided paths at the front of
sys.pathfor both command completions in the Editor (language server) and the IPython console.Requires:
python-lsp/python-lsp-server#139
spyder-ide/spyder-kernels#352
Issue(s) Resolved
Fixes #17066
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @mrclary